KhronosGroup / OpenCL-CTS

The OpenCL Conformance Tests
Apache License 2.0
184 stars 196 forks source link

printf is incorrectly testing vector arguments #2039

Closed coldav closed 1 month ago

coldav commented 1 month ago

https://github.com/KhronosGroup/OpenCL-CTS/pull/2019 added multiple vector tests including:

float3 tmp = (float3)(1234.25f,987654.5f,0.0005f); printf("%.2v3e\n",tmp);}

This does not include a length specifier. The spec says that "If a vector specifier appears without a length modifier, the behaviour is undefined. "

There are a few others like this.

bashbaug commented 1 month ago

Should we revert #2019 while we get this worked out? CC @shajder

svenvh commented 1 month ago

Alternatively (to a revert), I think this should fix the vector test too: https://github.com/KhronosGroup/OpenCL-CTS/pull/2044

shajder commented 1 month ago

Alternatively (to a revert), I think this should fix the vector test too: #2044

@svenvh is there anything more to do around this issue ?

svenvh commented 1 month ago

If #2044 gets merged I believe we can close this issue.