search

KhronosGroup / OpenCL-Headers

Khronos OpenCL-Headers
Apache License 2.0
666 stars 236 forks source link

Fix API suffix version macros for semaphore extensions command definitions #181

Closed kpet closed 2 years ago

kpet commented 2 years ago

These extensions only require OpenCL 1.2

Signed-off-by: Kevin Petit kevin.petit@arm.com

bashbaug commented 2 years ago

I think this is fine, though I do still question how useful these API suffixes are for extension APIs and what they should mean (see https://github.com/KhronosGroup/OpenCL-Headers/issues/153, especially https://github.com/KhronosGroup/OpenCL-Headers/issues/153#issuecomment-778386065).

Please note that these definitions were generated from the XML file so we should update the XML file for consistency too. If you don't want to create a PR just to update this, feel free to add it to the "minor issues" issue and I'll fix it shortly:

https://github.com/KhronosGroup/OpenCL-Docs/issues/696

Thanks!

kpet commented 2 years ago

Yeah, I just fixed them because they looked obviously wrong but I agree there's more thinking/work needed around those.

Please note that these definitions were generated from the XML file so we should update the XML file for consistency too.

Yup, that was on my list but I had to context switch. I've added it to the issue so we don't forget. I'll prepare a PR if you don't get there before me. Thanks!