search

KhronosGroup / OpenCL-Headers

Khronos OpenCL-Headers
Apache License 2.0
666 stars 236 forks source link

Add definitions for cl_arm_protected_memory_allocation #187

Closed kpet closed 2 years ago

kpet commented 2 years ago

Specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/727

Signed-off-by: Kevin Petit kevin.petit@arm.com

kpet commented 2 years ago

Oh yes, it's undefined behaviour. I've gone for ULL. This should have been caught by the CI. Maybe we can use Werror. I'll have a look.

kpet commented 2 years ago

So, we're already using Werror in the CI. We're not getting any warning here because the definition is not used by the test code. I've created https://github.com/KhronosGroup/OpenCL-Headers/issues/188 to address this.

kpet commented 2 years ago

@bashbaug Could you take another look please? We'd like to get this in ahead of an upcoming release. Thanks!