search

KhronosGroup / OpenCL-Headers

Khronos OpenCL-Headers
Apache License 2.0
666 stars 236 forks source link

use cinttypes instead of inttypes.h header for C++ tests #209

Closed bashbaug closed 2 years ago

bashbaug commented 2 years ago

see discussion: https://github.com/KhronosGroup/OpenCL-SDK/issues/58#issuecomment-1260074680

This change uses the cinttypes header when compiling C++ tests rather than the C-based inttypes.h header. Some versions of the inttypes.h header require also defining __STDC_FORMAT_MACROS to use the printf format macro constants used in the tests with C++ compiles, but not all. Switching to the cinttypes header seems to work in all cases.

juliohm commented 2 years ago

Appreciate if someone can merge this approved PR 🙏🏽