Closed bashbaug closed 1 year ago
If the pointer should really be const
we can merge #222 and we should be all set - thanks!
Thanks @bashbaug for catching this. Yes it indeed should be a constant pointer. I have fixed the doc to reflect that. Please merge #222.
Fixed by #222, closing. Thanks for the prompt responses!
Related to PR #220, sorry I didn't notice this before merging...
The code in the headers for clEnqueueWriteHostPipeINTEL is now: https://github.com/KhronosGroup/OpenCL-Headers/blob/e3e85862d6905eba9f4b5ed02c52effe673721d3/CL/cl_ext.h#L2548
In the XML file it is: https://github.com/KhronosGroup/OpenCL-Docs/blob/28bd8e10eaf66fc1c01c6156bb270f94f1a69c3c/xml/cl.xml#L4178
Note that the
ptr
isconst
in the XML file and non-const in the headers. I thinkconst
is correct, and hence these headers should be updated and not the XML file, but regardless they should be kept in sync. Let me know what you'd like to do - thanks!CC: @zibaiwan
PS: We really need to enable code generation for the headers to avoid issues like these!