search

KhronosGroup / OpenCL-Headers

Khronos OpenCL-Headers
Apache License 2.0
666 stars 236 forks source link

Use array for clUpdateMutableCommandsKHR #245

Closed EwanC closed 1 month ago

EwanC commented 9 months ago

Proposal to pass the update configs to clUpdateMutableCommandsKHR as an array, rather than pointer changed linked list. Generated from XML changes in https://github.com/KhronosGroup/OpenCL-Docs/pull/1045

See https://github.com/KhronosGroup/OpenCL-Docs/issues/1041 for motivation.

Related PRs:

EwanC commented 2 months ago

LGTM

Do we need to stage these changes with changes in any other repos, such as the C++ bindings (OpenCL-CLHPP) or the CTS tests?

I'll take care of updating the command buffer emulation layer.

Should probably be staged with CTS PR https://github.com/KhronosGroup/OpenCL-CTS/pull/1984, I don't have a OpenCL-CLHPP PR but will look into making one there. I'm not that familiar with the C++ bindings, but I'd expect that would break without an update.

Edit: created a OpenCL-CLHPP PR here will update https://github.com/KhronosGroup/OpenCL-CLHPP/pull/298