search

KhronosGroup / OpenCL-ICD-Loader

The OpenCL ICD Loader project.
Apache License 2.0
246 stars 136 forks source link

dynamically load functions for OpenCLon12 #197

Closed bashbaug closed 2 years ago

bashbaug commented 2 years ago

Note, this PR builds upon the changes in #186. When #186 is merged I will rebase this PR.

This PR (and specifically commit db1ceda7408cb7f36e4e5484794e42e6433d2f7c) contains the last of the changes needed to build a fully functional OpenCL ICD loader with mingw. It uses a similar mechanism as that used by #90 and #102 to dynamically load the functions needed to look for OpenCLon12.

Because these changes should work for all compilers now I have also removed the OPENCL_ICD_LOADER_DISABLE_OPENCLON12 CMake option.

Fixes #191 (because it builds upon #186) Fixes #11 Fixes #130

See also: https://github.com/KhronosGroup/OpenCL-SDK/issues/58

bashbaug commented 2 years ago

I think this one is ready to go now, too, now that CI is passing.

The diff looks clean now, but please let me know if I should rebase these changes vs. merging.

Kerilk commented 2 years ago

Changes look great. i don't think rebasing would yield significant improvements. I'll merge right away.