search

KhronosGroup / OpenCL-ICD-Loader

The OpenCL ICD Loader project.
Apache License 2.0
246 stars 136 forks source link

fix MacOS CI #198

Closed bashbaug closed 2 years ago

bashbaug commented 2 years ago

The GitHub actions macos-latest workflow was updated to macos-12 recently, which only has gcc-11. Switch back to macos-11 for now at least, to unblock MacOS CI.

Also updates the checkout action to v3 to eliminate CI warnings.

edit: macos-12 only has gcc-11, not gcc-12.

Kerilk commented 2 years ago

Thanks for fixing it! I supposed it was the issue, but GitHub action documentation is outdated and still lists macos-11 as latest. Apparently it is also not updated for everyone, as I am still getting macos-11 for my fork. I'll approve once I see a working test on MacOS.

Kerilk commented 2 years ago

Got to love github actions: "Error: Unable to resolve action actions/checkout@3, unable to find version 3" but only for MacOS Maybe rollback to actions/checkout@2 for MacOS only? Edit: I see you fixed it already... I thought they had a validation pass on these, I guess it doesn't check as much as I thought.

bashbaug commented 2 years ago

Yeah, I'm pretty sure this is it. I'm not sure exactly when the switch happened and it still looks like the docs are catching up, but there is some information and the announcement here:

https://github.com/actions/runner-images/issues/6384

I had a typo in my change to update the checkout actions (now fixed), but you can see the previous commit was successful. I'm pretty confident this latest update should be clean.

Kerilk commented 2 years ago

Looks good, I'll let it run approve and merge, this will unblock the rest.