search

KhronosGroup / OpenCL-ICD-Loader

The OpenCL ICD Loader project.
Apache License 2.0
246 stars 136 forks source link

Update path to pkg-config header file. #207

Closed Kerilk closed 1 year ago

Kerilk commented 1 year ago

This is the accompanying pull request for https://github.com/KhronosGroup/OpenCL-Headers/pull/218

The first commit refactors the way the CI handles PKG_CONFIG_PATH. The second commit updates the path to the newly adopted path in the Headers (failure is expected until the Headers are merged).

Kerilk commented 1 year ago

This looks good to me.

To merge this should we:

* First merge the OpenCL headers changes.

* Trigger a CI build.

* Merge the changes assuming all tests pass?

Yes this is the plan. I will rerun the failed tests once the headers changes is through.

bashbaug commented 1 year ago

Looks like everything is passing - awesome. Merging this one too...