KhronosGroup / OpenCL-ICD-Loader

The OpenCL ICD Loader project.
Apache License 2.0
246 stars 136 forks source link

do strings in the Windows resource file need a prefix #209

Open bashbaug opened 1 year ago

bashbaug commented 1 year ago

Found during a code review: https://github.com/KhronosGroup/OpenCL-ICD-Loader/pull/206#issuecomment-1432068544

When looking at: https://learn.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block It seems that "040904E4" means that the values should be in U.S. English and in Multilingual character set (0x04E4 == 1252). Thus shouldn't all the strings be prefixed by L here? Are we mixing character sets?

mmuetzel commented 1 year ago

CP1252 is a single byte character encoding: https://en.wikipedia.org/wiki/Windows-1252

So, single byte string literals should be fine.