KhronosGroup / OpenCL-ICD-Loader

The OpenCL ICD Loader project.
Apache License 2.0
246 stars 136 forks source link

Updated CI, added CD #226

Closed mfep closed 5 months ago

mfep commented 1 year ago

This PR is considered to be complete, albeit review remarks and/or changes to related PRs might warrant minor updates.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

Kerilk commented 11 months ago

Thanks for this contribution.

I don't know why the CI didn't trigger here. From what I understand it should have.

To get around the issue, I pushed the branch on my fork, but the CI failed: https://github.com/Kerilk/OpenCL-ICD-Loader/actions/runs/7093978723/job/19308386439 So if we merge this we will most probably break the CI.

mfep commented 11 months ago

Thanks for this contribution.

I don't know why the CI didn't trigger here. From what I understand it should have.

To get around the issue, I pushed the branch on my fork, but the CI failed: https://github.com/Kerilk/OpenCL-ICD-Loader/actions/runs/7093978723/job/19308386439 So if we merge this we will most probably break the CI.

Hi, and thank you for looking at this.

I also don't know why the CI didn't trigger, but I wouldn't be too surprised if it was for security reasons. Since this PR changed the CI script, this would be a way to execute arbitrary code on the KhronosGroup CI cluster, if it existed.

The reason for the CI failure in your fork is due to the additions to the formatting checker script. The new formatting checker is incremental, i.e. only changes between the current commit and origin/main are considered. Since the default branch of your fork is named master, the script fails.

This job has run on the same commit as this PR's head, and was successful: https://github.com/StreamHPC/OpenCL-ICD-Loader/actions/runs/6339722153

Beanavil commented 5 months ago

Latest commits: