Closed mfep closed 5 months ago
Thanks for this contribution.
I don't know why the CI didn't trigger here. From what I understand it should have.
To get around the issue, I pushed the branch on my fork, but the CI failed: https://github.com/Kerilk/OpenCL-ICD-Loader/actions/runs/7093978723/job/19308386439 So if we merge this we will most probably break the CI.
Thanks for this contribution.
I don't know why the CI didn't trigger here. From what I understand it should have.
To get around the issue, I pushed the branch on my fork, but the CI failed: https://github.com/Kerilk/OpenCL-ICD-Loader/actions/runs/7093978723/job/19308386439 So if we merge this we will most probably break the CI.
Hi, and thank you for looking at this.
I also don't know why the CI didn't trigger, but I wouldn't be too surprised if it was for security reasons. Since this PR changed the CI script, this would be a way to execute arbitrary code on the KhronosGroup CI cluster, if it existed.
The reason for the CI failure in your fork is due to the additions to the formatting checker script. The new formatting checker is incremental, i.e. only changes between the current commit and origin/main
are considered. Since the default branch of your fork is named master
, the script fails.
This job has run on the same commit as this PR's head, and was successful: https://github.com/StreamHPC/OpenCL-ICD-Loader/actions/runs/6339722153
Latest commits:
khronosgroup
Docker Hub are usedfix MSVC compiler toolset version due to breaking change in the MSVC versioning (see cppblog)
We have incremented the minor version number of the MSVC toolset from 19.39 (VS 2022 v17.9) to 19.40 (VS 2022 v17.10)
-Werror
//WX
is enabled in CI.
and..
dirs to ICD search paths when using layers.CMakeLists.txt
to be able to produce binary Debian packages usingcpack
.ocl-icd-libopencl1
)ocl-icd-opencl-dev
)cllayerinfo
executable.presubmit
workflow now.git-clang-format
.v*
tagDebSourcePkg.cmake
which is intended to run in CMake script mode. This script generates thedebian/control
,debian/changelog
and`debian/rules
files which are required to build a Debian source package.khronos-opencl-loader
, which is also the name of the source package that is generated. Thereby the 3 binary packages are named the following:khronos-opencl-loader-libopencl1
khronos-opencl-loader-opencl-dev
khronos-opencl-loader-cllayerinfo
ocl-icd-libopencl1
,khronos-opencl-loader-libopencl1
does not conflict with other packages providing virtual packagelibopencl1
. Instead it uses the update-alternatives program so that it can be co-installed with other packages providinglibopencl1
, given that those packages are also equipped with the update-alternatives integration. This update-alternatives integration is not present in the CPack generated binary package.This PR is considered to be complete, albeit review remarks and/or changes to related PRs might warrant minor updates.