Closed jenatali closed 9 months ago
Looks like the CI run hit an infrastructure issue (timeout retrieving GPG key). I don't see an option to re-run it but I'm not super familiar with the GitHub actions UI. Might just be a permission issue though.
Launched a rerun of the failed jobs.
@bashbaug @MathiasMagnus Do we want to add the above configuration to the CI? Or merge this as is and try to remember about this?
This seems like a good change. We should probably test both calling conventions, but I'd defer it via an issue of its own.
I added an issue to track adding this case to CI, so we don't lose track of it. Let's just merge this now.
There's command-line switches which can change the default calling convention for unannotated functions. Visual Studio defaults to
/Gd
which is__cdecl
, but Windows defaults to/Gz
which is__stdcall
. That causes an x86 build break, sinceqsort
requires the input parameter to be__cdecl
. Just add the explicit annotation so it works regardless of the default.