search

KhronosGroup / OpenCL-Registry

OpenCL API and Extension Registry.
112 stars 42 forks source link

Indicate deprecation of cl.hpp in favor of OpenCL-CLHPP #120

Closed eyalroz closed 2 years ago

eyalroz commented 2 years ago

In this repository:

https://github.com/KhronosGroup/OpenCL-CLHPP

you have newer C++ bindings for various OpenCL versions, than the version you have here. If this repository is staying up, please at least indicate that it is not the newest version, and provide a link to the newer repository for cl.hpp.

bashbaug commented 2 years ago

Interesting, I didn't even know we had a copy of cl.hpp here!

I'm inclined to just remove the file from this repo. The registry webpage already points to the OpenCL-CLHPP repo as the source for the C++ bindings: https://www.khronos.org/registry/OpenCL/

Seem reasonable?

eyalroz commented 2 years ago

Well, since you asked...

I would think that it's that repository which should cease to exist. If there's an "OpenCL registry" repo (which isn't going away), the C++ bindings should be part of it, not split off into OpenCL-CLHPP; and the web page should point here instead.

bashbaug commented 2 years ago

Hi @eyalroz, we discussed this issue our weekly teleconference and we're going to remove the cl.hpp from this repo in favor of the OpenCL-CLHPP repo - see PR #124. Thanks for bring this issue to our attention!

eyalroz commented 2 years ago

@bashbaug : Ok, but - in this case, please consider linking to the CLHPP repo from this repository's README.md.

alycm commented 2 years ago

This ticket is closed as the PR addressing it has merged. I see there is an additional comment about linking to OpenCL-CLPP repo in the README. This repo is used to generate the registry webpage and the repository is linked there, i.e. here in the source, so I think that is covered.

eyalroz commented 2 years ago

@alycm : I think people reaching this repository rather than the registry webpage would appreciate a link via the main README.