publish ext image extensions

KhronosGroup / OpenCL-Registry

OpenCL API and Extension Registry.

112 stars 42 forks source link

publish ext image extensions #141

Closed bashbaug closed 1 year ago

bashbaug commented 1 year ago

cl_ext_image_from_buffer (spec source PR: https://github.com/KhronosGroup/OpenCL-Docs/pull/752)
cl_ext_image_requirements_info (spec source PR: https://github.com/KhronosGroup/OpenCL-Docs/pull/750)

bashbaug commented 1 year ago

@kpet heads up, I've converted this PR to a "draft" because there are a few issue I think we'll want to fix in the extension source before publishing:

The biggest of these is that the cl_ext_image_requirements_info spec still says "draft spec, not approved", and is still described as being version 0.5. I think these extension are shipping, in which case the status and the version should be updated.
There are a few minor editorial issues with mismatched parentheses and slightly odd indentation. Nothing critical, but if we're updating the specs anyhow it would be nice to fix these.
I did a quick review of the cl_ext_image_from_buffer spec and it mostly looks OK to me, but it might be worth a quick read through also.

Thanks!

kpet commented 1 year ago

@bashbaug I've created https://github.com/KhronosGroup/OpenCL-Docs/pull/942 to tidy up the sources. I see what you mean regarding the indentation but I've exhausted the time I could afford to spend convincing asciidoctor to not do that. I don't think it's ugly enough to require blocking publication but if you happen to know the magic runes to align those paragraphs, any pointers would be welcome! :)

bashbaug commented 1 year ago

I've rebuilt the specs after merging https://github.com/KhronosGroup/OpenCL-Docs/pull/942. I think this is ready to go now.

For the record, I think it's a little weird to publish a shipping spec as v0.5, but if this is intended I don't think it should block publication.

Thanks!

bashbaug commented 1 year ago

Here are some links to help review: