search

KhronosGroup / OpenCL-Registry

OpenCL API and Extension Registry.
112 stars 42 forks source link

Fix various token suffixing and related issues with mipmap extension ref #55

Closed oddhack closed 5 years ago

oddhack commented 5 years ago

Fixes #12, raises other issues. There's a ton of things messed up here. I started fixing the 2.0 / 2.1 ref pages to add KHR suffixes, and discovered that the CL_FILTER_NONE token doesn't even exist, FILTER_NEAREST is used instead. Also, while the CL_SAMPLER_MIP_FILTER_MODE, CL_SAMPLER_LOD_MIN, and CL_SAMPLER_LOD_MAX tokens have KHR suffixes in the 2.1 and 2.2 extension specs, they do not have suffixes in the 2.0 / 2.1 headers in the OpenCL-Headers repository.

Given all this I'm going to punt this off to the CL working group to see what they want to do. Realistically I think the most that could be done in the headers is to add _KHR aliases of the non-suffixed tokens that have been in there for a long time. The 2.1 / 2.2 extension specs are consistent with each other and should be controlling, the ref pages should (and do, with this PR) reflect the specs.

If reviewing the diff listing, I suggest turning on "Hide whitespace changes" (or whatever exactly it's called) in the diff options button - there were a bunch of trailing spaces which got eaten by my editor.

oddhack commented 5 years ago

Accepting this, to match https://github.com/KhronosGroup/OpenCL-Headers/pull/36