search

KhronosGroup / OpenCL-SDK

OpenCL SDK
Apache License 2.0
577 stars 120 forks source link

Ignore generated files from CMake, VS, XCode #39

Closed LeonBrands closed 2 years ago

LeonBrands commented 2 years ago

This makes building the CMake project inside of the source folder (instead of inside of the build/ folder) more convenient

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

MathiasMagnus commented 2 years ago

Summoning @bashbaug and/or @kpet to share their thoughts, as the contribution in question is mildly contentious.

I'm personally reluctant to provide any support for doing in-source builds as they are universally discouraged, at least as far as CMake goes. If in-source builds break for someone and they point to us "giving consent", those aren't fixes I would like to handle.

Making the in-source builds less painful are totally doable on your end as well. Placing these into the cloned project under .git/info/exclude it will persist on your end without having to update .gitignore (This is what I do on my end when it's needed). If in-source builds are something you regularly do, I'd suggest registering a user .gitignore file as detailed here.

LeonBrands commented 2 years ago

The maintenance point is very understandable 🙂 I'll close this and handle it locally instead.