search

KhronosGroup / OpenCL-SDK

OpenCL SDK
Apache License 2.0
578 stars 120 forks source link

Implemented external memory sample #90

Open mfep opened 1 year ago

mfep commented 1 year ago

NOTE: this PR includes all commits from branch StreamHPC:release-cd. This is required, because the implemented sample requires additional updates to the CI scripts to pull its new dependencies. After #88 is merged, this should be trivial to rebase/merge. Only the last commit is relevant for the sample, all other commits are from the release-cd branch.

bashbaug commented 6 months ago

There is a merge conflict here that needs to be resolved, also.

Beanavil commented 6 months ago

Addressed the comments and rebased onto StreamHPC/release-cd. There are some test failures from the other tests of the repo, but I think those are due to release-cd still being worked on to solve some new issues after rebasing. It's probably better to wait until #88 is ready to merge and rebase this one onto it.

Beanavil commented 1 month ago

@bashbaug about the Windows crash: unfortunately, I'm only able to run this sample in Windows through the CI and debugging it is rather slow. I checked the error that the sample produced, and it was the 0xc0000135, which means there was a missing DLL (the vulkan-1.dll one it seems). As expected, installing the Vulkan loader fixed that error, but then the example still fails with a 0xc0000139. I think this error is an "Entry point not found" (some DLL is being loaded but that cannot find the other DLLs it relies on), so it may be that other Vulkan-related dependencies are missing. I'll look further into this sometime this week if that's okay.

Beanavil commented 2 weeks ago