search

KhronosGroup / OpenCOLLADA

652 stars 252 forks source link

COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h: Include pcre.h #582

Open devurandom opened 6 years ago

devurandom commented 6 years ago

This fixes a compilation error with libpcre-8.42:

error: conflicting declaration 'typedef struct real_pcre8_or_16 pcre'

Also remove inclusion of pcre.h from files already including COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h

Closes: #547 Closes: #570 Depends-On: #581

Fl4reBot commented 6 years ago

FAILURE: exercise-opencollada-pull-request build #143

Pull Requests:

RemiArnaud commented 6 years ago

broken jenkins computer (HW failure)..

RemiArnaud commented 6 years ago

I relaunched the build, but this is not a Jenkins issue only. those changes break the build everywhere

for example:

on windows: e:\git\workspace\collada-max-pc-pull-request\colladabaseutils\include\COLLADABUPcreCompiledPattern.h(16): fatal error C1083: Cannot open include file: 'pcre.h': No such file or directory [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAFramework\scripts\COLLADAFramework.vcxproj]

on mac: openCOLLADA-mac-pull-request/COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h:16:10: fatal error: 'pcre.h' file not found

include

Fl4reBot commented 6 years ago

FAILURE: exercise-opencollada-pull-request build #150

Pull Requests: