KhronosGroup / OpenCOLLADA

652 stars 251 forks source link

Added animation clip parsing and writer callbacks #592

Closed lasalvavida closed 5 years ago

lasalvavida commented 5 years ago

Resolves #565 and enables multiple animations support in COLLADA2GLTF: https://github.com/KhronosGroup/COLLADA2GLTF/issues/130.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

Fl4reBot commented 5 years ago

FAILURE: exercise-opencollada-pull-request build #153

Pull Requests:

RemiArnaud commented 5 years ago

In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:5:0, from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1: /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:42: error: ‘AnimationClip’ does not name a type virtual bool writeAnimationClip( const AnimationClip animationClip ) = 0; ^ /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:57: error: ISO C++ forbids declaration of ‘animationClip’ with no type [-fpermissive] virtual bool writeAnimationClip( const AnimationClip animationClip ) = 0; ^ /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp: In function ‘void parse(char, ValidationErrorHandler&)’: /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:33:11: error: cannot declare variable ‘writer’ to be of abstract type ‘Writer’ ::Writer writer; ^ In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1:0: /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:13:7: note: because the following virtual functions are pure within ‘Writer’: class Writer : public COLLADAFW::IWriter ^ In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:5:0, from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1: /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:16: note: virtual bool COLLADAFW::IWriter::writeAnimationClip(const int) virtual bool writeAnimationClip( const AnimationClip* animationClip ) = 0;

lasalvavida commented 5 years ago

Thanks @RemiArnaud. Will fix.

Fl4reBot commented 5 years ago

FAILURE: exercise-opencollada-pull-request build #154

Pull Requests:

Fl4reBot commented 5 years ago

FAILURE: exercise-opencollada-pull-request build #155

Pull Requests:

RemiArnaud commented 5 years ago

..\src\COLLADAMaxColladaImporter.cpp(127): error C2259: 'COLLADAMax::DocumentImporter' : cannot instantiate abstract class [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] due to following members: 'bool COLLADAFW::IWriter::writeAnimationClip(const COLLADAFW::AnimationClip *)' : is abstract ....\COLLADAFramework\include\COLLADAFWIWriter.h(115) : see declaration of 'COLLADAFW::IWriter::writeAnimationClip'

(was the previous build) issue

Fl4reBot commented 5 years ago

FAILURE: exercise-opencollada-pull-request build #156

Pull Requests:

RemiArnaud commented 5 years ago

COLLADA-MAX:

COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: cdecl COLLADASaxFWL::LibraryAnimationClipsLoader::LibraryAnimationClipsLoader(class COLLADASaxFWL::IFilePartLoader *)" (??0LibraryAnimationClipsLoader@COLLADASaxFWL@@QEAA@PEAVIFilePartLoader@1@@Z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endlibrary_animation_clips(void)" (?endlibrary_animation_clips@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::beginanimation_clip(struct COLLADASaxFWL14::animation_clipAttributeData const &)" (?beginanimation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUanimation_clipAttributeData@COLLADASaxFWL14@@@Z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endanimation_clip(void)" (?endanimation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begininstance_animation(struct COLLADASaxFWL14::instance_animationAttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUinstance_animationAttributeData@COLLADASaxFWL14@@@Z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endinstance_animation(void)" (?endinstance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endlibrary_animation_clips(void)" (?endlibrary_animation_clips@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::beginanimation_clip(struct COLLADASaxFWL15::animation_clipAttributeData const &)" (?beginanimation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUanimation_clipAttributeData@COLLADASaxFWL15@@@Z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endanimation_clip(void)" (?endanimation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begininstance_animation(struct COLLADASaxFWL15::instance_animationAttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUinstance_animationAttributeData@COLLADASaxFWL15@@@Z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endinstance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj] ..\bin\win\x64\Release_Max2011\COLLADAMaxNew.dle : fatal error LNK1120: 11 unresolved externals [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]

COLLADA-MAYA: 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: cdecl COLLADASaxFWL::LibraryAnimationClipsLoader::LibraryAnimationClipsLoader(class COLLADASaxFWL::IFilePartLoader *)" (??0LibraryAnimationClipsLoader@COLLADASaxFWL@@QEAA@PEAVIFilePartLoader@1@@Z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endlibrary_animation_clips(void)" (?endlibrary_animation_clips@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::beginanimation_clip(struct COLLADASaxFWL14::animation_clipAttributeData const &)" (?beginanimation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUanimation_clipAttributeData@COLLADASaxFWL14@@@Z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endanimation_clip(void)" (?endanimation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begininstance_animation(struct COLLADASaxFWL14::instance_animationAttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUinstance_animationAttributeData@COLLADASaxFWL14@@@Z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::endinstance_animation(void)" (?endinstance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endlibrary_animation_clips(void)" (?endlibrary_animation_clips@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::beginanimation_clip(struct COLLADASaxFWL15::animation_clipAttributeData const &)" (?beginanimation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUanimation_clipAttributeData@COLLADASaxFWL15@@@Z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endanimation_clip(void)" (?endanimation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begininstance_animation(struct COLLADASaxFWL15::instance_animationAttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUinstance_animationAttributeData@COLLADASaxFWL15@@@Z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::endinstance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj] 2>..\bin\win\x64\ReleasePlugin2018\COLLADAMaya.mll : fatal error LNK1120: 11 unresolved externals [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]