search

KhronosGroup / OpenGL-Refpages

OpenGL and OpenGL ES reference page sources, and generated HTML used as backing store for khronos.org
427 stars 134 forks source link

Change CDN from MathJax to Cloudflare #101

Closed TestingPlant closed 2 years ago

TestingPlant commented 3 years ago

This is just a find and replace from the old CDN to the new one and to also add a closing script tag.

oddhack commented 2 years ago

Sorry, overlooked this. The problem is that the .xhtml files are all generated. The CDN reference is coming from html/opengl-man.xsl in each refpage set, so updating that should be all that's needed for this PR - I can regenerate the XHTML outputs once that's done. But I'm also unclear where the CDN URL you're using came from? I haven't paid attention to this stuff for a long time and the mathjax.org docs have moved on to v3, where they seem to be recommending cdn.jsdelivr.net (see https://docs.mathjax.org/en/latest/web/configuration.html#loading-mathjax). I'm unsure if that recommendation applied to v2 as well.

oddhack commented 2 years ago

Closing this - #112 does the same thing functionally but propagates the new CDN URL into the XSL used for processing Docbook rather than editing output files directly. Thanks!

oddhack commented 2 years ago

N.b. the closing script tag doesn't seem to propagate through the XSL Docbook toolchain, or at least I didn't spend enough time to figure it out, but if you can feel free to propose another PR (would need to edit opengl-man.xsl in each refpage set, probably). I don't think it functionally makes any difference in practice? Maybe some validators complain though.