KhronosGroup / OpenGL-Refpages

OpenGL and OpenGL ES reference page sources, and generated HTML used as backing store for khronos.org
424 stars 131 forks source link

Fix off-by-one in glGenerateMipMap #126

Closed Pokechu22 closed 10 months ago

Pokechu22 commented 1 year ago

Closes #104.

This phrasing is used in the OpenGL 4.6 (section 8.14.4/page 266) and 3.0 (page 212) specifications; this was only a typo in the refpages.

The ES versions did not have this issue, though they do have misleading comments in some places, using the same text for base + 1 and base). I haven't changed those since I'm not sure why the ES versions don't use the same $ syntax, and also the comment doesn't end up in the generated HTML.

There are a few other oddities; currently, only ES 2.0 mentions that "No particular filter algorithm is required" and that glHint/GL_GENERATE_MIPMAP_HINT exists (later ES versions still mention GL_GENERATE_MIPMAP_HINT in glHint's page, but don't have a link from glGenerateMipmap, while GL_GENERATE_MIPMAP_HINT was deprecated in OpenGL 3.1 but remains in ES from what I can see). I haven't touched those either, but the "No particular filter algorithm is required" was the information I was originally looking for and still is in the OpenGL 4.6 spec.