search

KhronosGroup / OpenGL-Refpages

OpenGL and OpenGL ES reference page sources, and generated HTML used as backing store for khronos.org
435 stars 135 forks source link

Void vs GLVoid #53

Closed davidgumberg closed 4 years ago

davidgumberg commented 5 years ago

From gl4/glBufferData.xml

    <funcsynopsis>
      <funcprototype>
        <funcdef>void <function>glBufferData</function></funcdef>

        <paramdef>GLenum <parameter>target</parameter></paramdef>

        <paramdef>GLsizeiptr <parameter>size</parameter></paramdef>

        <paramdef>const GLvoid * <parameter>data</parameter></paramdef>

        <paramdef>GLenum <parameter>usage</parameter></paramdef>
      </funcprototype>

      <funcprototype>
        <funcdef>void <function>glNamedBufferData</function></funcdef>

        <paramdef>GLuint <parameter>buffer</parameter></paramdef>

        <paramdef>GLsizei <parameter>size</parameter></paramdef>

        <paramdef>const void *<parameter>data</parameter></paramdef>

        <paramdef>GLenum <parameter>usage</parameter></paramdef>
      </funcprototype>
    </funcsynopsis>
  </refsynopsisdiv>

Should all of these void instances be GLvoid instead

oddhack commented 5 years ago

Thanks for noticing this. I'd say the fix is the opposite - 'GLvoid' was a silly idea, and we've removed it from gl.xml in favor of 'void'. The same change ought to be done in the refpages, where it occurs in about 170 places - I'll take an action for that but probably won't get to it soon.

vallentin commented 5 years ago

@oddhack I can run through everything and replace all GLvoid with void, if you'd like that.

oddhack commented 4 years ago

Should all be fixed now.