KhronosGroup / OpenGL-Refpages

OpenGL and OpenGL ES reference page sources, and generated HTML used as backing store for khronos.org
435 stars 135 forks source link

GL_VERTEX_BINDING_BUFFER and GL_VERTEX_ATTRIB_BINDING missing #54

Open vhirtham opened 5 years ago

vhirtham commented 5 years ago

Hello,

during a discussion in the OpenGL forum we discovered that GL_VERTEX_ATTRIB_BINDING is missing in the documentation of glGetVertexAttribiv (link) and GL_VERTEX_BINDING_BUFFER in the documentation of glGetIntegeri_v (link). For what I have seen they are in the specs (Table 23.4 - Page 565 - OpenGL 4.5 specs)

Greetings

oddhack commented 5 years ago

Thanks for the report @vhirtham - would you be willing and able to propose an MR to the corresponding refpages in this repo? It looks like the problem affects ES as well and goes back to GL 2.1, so probably all the glGetVertexAttrib.xml in the registry would need to be tweaked :-(

vhirtham commented 5 years ago

@oddhack I can try :) - I will see what I can do but it has to wait until next week. I will start with the gl4 folder and open a pull request once it is done. If my changes got accepted I can just copy the modifications to the other versions and update the PR.

oddhack commented 4 years ago

I hadn't accepted this because there were some remaining issues, but went ahead and took it now to clear the PR off the table. The remaining issues were, per my original comment on #58:


For the other versions of the refpages, here's what I can see:

So if you want to make the corresponding updates to the other refpages, that would be appreciated. If not we can just accept this as is, and keep #54 open for future fixes. It is unfortunately tedious to have all these different refpage sets to keep maintained, but rewriting them to do version conditionals in the Docbook source, or to a better source format like asciidoctor, would be an enormous task we don't have resources for right now.