Fix issue #54 - Githubissues

KhronosGroup / OpenGL-Refpages

OpenGL and OpenGL ES reference page sources, and generated HTML used as backing store for khronos.org

427 stars 134 forks source link

Fix issue #54 #58

Closed vhirtham closed 4 years ago

vhirtham commented 5 years ago

As discussed in issue #54 I added the missing entries to the glGet and glGetVertexAttrib files for OpenGL 4.x. Additionally I added also missing entries for GL_VERTEX_ATTRIB_ARRAY_LONG and GL_VERTEX_ATTRIB_RELATIVE_OFFSET in the glGetVertexAttrib file. They are mentioned in the 4.6 specifications at page 375.

If you think the changes are okay and if you tell me in which versions those entries are also missing, I can copy them to the corresponding files.

oddhack commented 5 years ago

This looks good. For the other versions of the refpages, here's what I can see:

VERTEX_ATTRIB_ARRAY_BUFFER_BINDING was added in OpenGL 2.0 and ES 2.0, so applies to all the refpage sets except those under 'es1.1/'.
VERTEX_ATTRIB_ARRAY_LONG was added in GL 4.3, applies to the 'gl4/' refpages.
VERTEX_ATTRIB_RELATIVE_OFFSET and VERTEX_BINDING_BUFFER were added in GL 4.3 and ES 3.1, so apply to the 'gl4/', 'es3/', and 'es3.1/' refpages.

So if you want to make the corresponding updates to the other refpages, that would be appreciated. If not we can just accept this as is, and keep #54 open for future fixes. It is unfortunately tedious to have all these different refpage sets to keep maintained, but rewriting them to do version conditionals in the Docbook source, or to a better source format like asciidoctor, would be an enormous task we don't have resources for right now.

vhirtham commented 5 years ago

Give me some days and I will add the entries to the mentioned folders ;)

oddhack commented 4 years ago

I didn't get back to this since it wasn't updated - going ahead and merging now. If you want to submit a separate PR addressing the other issues that would be great - I'm going to post my comment above back to #54 as a tracker.