search

KhronosGroup / OpenGL-Registry

OpenGL, OpenGL ES, and OpenGL ES-SC API and Extension Registry
679 stars 274 forks source link

Remove 'u' from NV_shader_atomic_uint64 GLASM option #471

Closed ReinUsesLisp closed 3 years ago

ReinUsesLisp commented 3 years ago

Rename the GLASM option NV_shader_atomic_uint64 to NV_shader_atomic_int64 (remove the 'u' in 'uint64').

The implementation of this extension checks for NV_shader_atomic_int64 and signals uint64 as invalid. The extension itself is named without the 'u', and applications relying on this would break if the driver is changed, so I assume it's a typo.

I think changing the spec to match the current behavior is the path with less friction. I considered opening an issue about this, but opted to open this pull request given the simplicity of the change. Let me know if I missed something so it can be amended.

If the approach here is wrong, please close this pull request.

oddhack commented 3 years ago

@pdaniell-nv this is something for NVIDIA to sign off on.

nvpbrown commented 3 years ago

@pdaniell-nv pointed me at this. The proposed edits look fine to me; it appears that the original language had a typo that probably replicated via cut-and-paste. The only issue I have is that the edit should also include a new revision number in the document header and a new entry in the revision history section of the document.

Thanks for finding and reporting this issue.

-- Pat