search

KhronosGroup / OpenGL-Registry

OpenGL, OpenGL ES, and OpenGL ES-SC API and Extension Registry
679 stars 274 forks source link

Removed unnecessary COMPSIZE for all glMultiDraw* functions #475

Closed NogginBops closed 3 years ago

NogginBops commented 3 years ago

Removed COMPSIZE from the len attributes from the parameters to applicable glMultiDraw* functions.

// https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glMultiDrawArrays.xhtml
glMultiDrawArrays
glMultiDrawArraysEXT

//https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glMultiDrawElements.xhtml
glMultiDrawElements
glMultiDrawElementsEXT

// https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glMultiDrawElementsBaseVertex.xhtml
glMultiDrawElementsBaseVertex
glMultiDrawElementsBaseVertexEXT

// https://www.ibm.com/docs/en/aix/7.1?topic=subroutines-glmultimodedrawarraysibm-subroutine
glMultiModeDrawArraysIBM
// https://www.ibm.com/docs/en/aix/7.1?topic=subroutines-glmultimodedrawelementsibm-subroutine
glMultiModeDrawElementsIBM

I also added COMPSIZE to three functions:

// https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glMultiDrawArraysIndirect.xhtml
glMultiDrawArraysIndirect

// https://www.khronos.org/registry/OpenGL/extensions/AMD/AMD_multi_draw_indirect.txt
glMultiDrawArraysIndirectAMD
glMultiDrawElementsIndirectAMD

This should be putting good len attributes on almost all glMultiDraw* functions. There are a few functions from nvidia extensions that would require some weird COMPSIZE` stuff that I decided wasn't worth figuring out.

It would be great if someone could double check my changes as interpreting docs is pretty error prone.

pdaniell-nv commented 3 years ago

@oddhack are you okay with this change?

pdaniell-nv commented 3 years ago

@oddhack this is approved to merge.