search

KhronosGroup / OpenGL-Registry

OpenGL, OpenGL ES, and OpenGL ES-SC API and Extension Registry
678 stars 274 forks source link

Enum fixes found while making #534 #546

Closed NogginBops closed 1 year ago

NogginBops commented 1 year ago

These are some enum fixes that I found while making #534.

SunSerega commented 1 year ago

Same as I said in #534 here, I don't think glSpriteParameterfvSGIX should get this group, at least for now. The values of that group are acceptable, but it doesn't make sense to pass enum values as a float when there is an overload for an integer.

NogginBops commented 1 year ago

I have removed the group from the parameter now. I can agree that it doesn't make much sense to put the group on that parameter.

SunSerega commented 1 year ago

Well, I meant the same for glSpriteParameterfSGIX (without 'v'), but I also don't have as strong of an opinion on it because there the workaround is trivial. And either way this is temporary and a proper system for describing influence of pname parameter is needed.

NogginBops commented 1 year ago

I missed glSpriteParameterfSGIX, fixed!

SunSerega commented 1 year ago

Since it's connected to #534 - it's also ready to be un-drafted.

pdaniell-nv commented 1 year ago

@oddhack this is approved to merge.