KhronosGroup / OpenGL-Registry

OpenGL, OpenGL ES, and OpenGL ES-SC API and Extension Registry
678 stars 274 forks source link

Added GL_AMBIENT, GL_DIFFUSE and GL_SPECULAR enumerants to LightParameter group #578

Closed Rytis-Stan closed 1 year ago

Rytis-Stan commented 1 year ago

Looks like the mentioned enumerants were "lost" from the "LightParameter" group in the commit 8794952a2dfe6332e269191b1288995059df30fd. Here is how the "LightParameter" group looked like just before the changes:

        <group name="LightParameter" comment="Deprecated, use the group attributes instead.">
            <enum name="GL_AMBIENT"/>
            <enum name="GL_CONSTANT_ATTENUATION"/>
            <enum name="GL_DIFFUSE"/>
            <enum name="GL_LINEAR_ATTENUATION"/>
            <enum name="GL_POSITION"/>
            <enum name="GL_QUADRATIC_ATTENUATION"/>
            <enum name="GL_SPECULAR"/>
            <enum name="GL_SPOT_CUTOFF"/>
            <enum name="GL_SPOT_DIRECTION"/>
            <enum name="GL_SPOT_EXPONENT"/>
        </group>

Re-adding the missing enumerants.

Related PR: https://github.com/KhronosGroup/OpenGL-Registry/pull/579

pdaniell-nv commented 1 year ago

@Perksey Do you want to review this since https://github.com/KhronosGroup/OpenGL-Registry/commit/8794952a2dfe6332e269191b1288995059df30fd was your change?

pdaniell-nv commented 1 year ago

@oddhack, this is approved to merge.