search

KhronosGroup / OpenGL-Registry

OpenGL, OpenGL ES, and OpenGL ES-SC API and Extension Registry
677 stars 274 forks source link

Allocate enums for Qualcomm #609

Closed MatAshish closed 4 months ago

oddhack commented 4 months ago

LGTM. Is this ready to merge?

MatAshish commented 4 months ago

Yes, ready to merge.

MatAshish commented 4 months ago

Can this be accepted onto the main branch ?

oddhack commented 4 months ago

Can this be accepted onto the main branch ?

Yes, sorry. We just had a face to face Khronos meeting and not a lot gets done the week after that.

SunSerega commented 4 months ago

Everywhere else in XML the vendor="QCOM" is used, but here vendor="Qualcomm" was added.

I can make a quick PR to make it the same everywhere, but which of the 2 would you prefer to keep, @MatAshish?

P.S. Also, shouldn't the GetTexParameter group instead be called GetTextureParameter? And TexParameterI should probably be TextureParameterName...

MatAshish commented 4 months ago

@SunSerega : Thanks for pointing out. I based vendor as "Qualcomm" on a previous check-in in the same file for GL_FRAMEBUFFER_FETCH_NONCOHERENT_QCOM. Looks like it was a mistake and we can take "QCOM" to be consistent. I will make another pull request with TextureParameterName and QCOM.