Closed MatAshish closed 4 months ago
Yes, ready to merge.
Can this be accepted onto the main branch ?
Can this be accepted onto the main branch ?
Yes, sorry. We just had a face to face Khronos meeting and not a lot gets done the week after that.
Everywhere else in XML the vendor="QCOM"
is used, but here vendor="Qualcomm"
was added.
I can make a quick PR to make it the same everywhere, but which of the 2 would you prefer to keep, @MatAshish?
P.S. Also, shouldn't the GetTexParameter
group instead be called GetTextureParameter
?
And TexParameterI
should probably be TextureParameterName
...
@SunSerega : Thanks for pointing out. I based vendor as "Qualcomm" on a previous check-in in the same file for GL_FRAMEBUFFER_FETCH_NONCOHERENT_QCOM. Looks like it was a mistake and we can take "QCOM" to be consistent. I will make another pull request with TextureParameterName and QCOM.
LGTM. Is this ready to merge?