search

KhronosGroup / OpenVX-cts

OpenVX Conformance Test Suite
Apache License 2.0
9 stars 6 forks source link

BilateralFilter problems #18

Open asdor opened 4 years ago

asdor commented 4 years ago
  1. Input tensor may have 2 or 3 dimensions. Standard says:

    In case of 3 dimensions the 1st dimension of the vx_tensor. Which can be of size 1 or 2. Or the value in the tensor in the case of tensor with 2 dimensions.

But in test BIlateralFilter.NodeCreation all sizes of dimensions vary from 1 to 20. But the size of the first dimension must be 1 or 2.
The same problem is in BilateralFilter data tests, where in 3d case the first dimension is set to 3.

  1. When border mode is VX_BORDER_CONSTANT, in code if x or y coordinate is negative, then a constant value is selected.
    But this works only for top and left border. On the bottom and right border, it looks like it works in replicate mode.
kiritigowda commented 4 years ago

@asdor, thanks for filing this bug. We are fixing this in our internal repo. The fixed branch will be synced to GitHub.

jessegv commented 4 years ago

@asdor , can you confirm that the fix reference here fixes your issue? https://github.com/KhronosGroup/OpenVX-cts/commit/b4f725f6f574a91c4db07c5b82d18aa4fd280e92

RobertCall commented 4 years ago

Second bug not fixed This line should be like this