search

KhronosGroup / OpenXR-Docs

OpenXR Specification sources and related material
Other
143 stars 62 forks source link

[loader]doc: Use nativeLibraryDir to replace getNativeLibraryDir() #108

Closed utzcoz closed 2 years ago

utzcoz commented 3 years ago

ApplicationInfo doesn't have method called getNativeLibraryDir(), and it only has nativeLibraryDir field, used by OpenXR loader source code. See https://developer.android.com/reference/android/content/pm/ApplicationInfo#nativeLibraryDir and https://gitlab.freedesktop.org/monado/utilities/openxr-android-broker/-/blob/main/utils/src/main/java/org/khronos/openxr/runtime_broker/utils/RuntimeData.java#L257-261.

Looks like the OpenXR-Docs repository doesn't host loader spec source code. There is a related PR for it at OpenXR-SDK-Source: https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/278. As @rpavlik said at https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/278#issuecomment-961363172, this issue is created at OpenXR-Doc for CLA reasons.

rpavlik commented 3 years ago

Oh.... I was pretty sure it was supposed to be in here. Ok, guess I'll merge the other one. 🤦

utzcoz commented 3 years ago

Oh.... I was pretty sure it was supposed to be in here. Ok, guess I'll merge the other one. facepalm

I have saw build target for loader at spec Makefile from old PRs.

rpavlik commented 2 years ago

Merged over there, thanks!