search

KhronosGroup / OpenXR-Docs

OpenXR Specification sources and related material
Other
143 stars 62 forks source link

XR_KHR_convert_timespec_time: fix typos #113

Closed bl4ckb0ne closed 2 years ago

bl4ckb0ne commented 2 years ago

XR_KHR_convert_timespec_time was referring to the timespec argument as timespecTime in the functions signatures, and unixTime in the documentation.

I chose to change it to ts when fixing it, as it is how the struct timespec is commonly referred to.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

rpavlik commented 2 years ago

Good catch!

I'd be more comfortable merging (without additional WG approval) a patch that just updates the .adoc file to match the xml (timespecTime), which is the canonical representation of the API. (Isn't ts usually the structure, though, rather than a pointer, anyway?)

bl4ckb0ne commented 2 years ago

I usually use/see struct timespec *ts out there, but I made the change to use timespecTime everywhere.

bl4ckb0ne commented 2 years ago

Seems to be an issue with the CI: "Error: HttpError: Resource not accessible by integration". Did I missed enabling something somewhere?

rpavlik commented 2 years ago

We don't merge directly to master in this repo.

rpavlik-bot commented 2 years ago

An issue (number 1653) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1653 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.