search

KhronosGroup / OpenXR-Docs

OpenXR Specification sources and related material
Other
141 stars 62 forks source link

Proposal for the OPPO vendor extension #146

Closed hjiang36 closed 1 year ago

hjiang36 commented 1 year ago

Recreate pull request for OPPO vendor extension proposal to rebase commits to latest releases / staging. The original pull request was in https://github.com/KhronosGroup/OpenXR-Docs/pull/144

@rpavlik @Wallbraker It seems like there is a new release last week and I rebase the unmerged part of work from pr144 to here. Let me know if there is something I could do to move this forward.

Thanks a lot.

rpavlik-bot commented 1 year ago

An issue (number 1963) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1963 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

rpavlik commented 1 year ago

There are people on the working group who are concerned with your suggested naming (of the component with just controller), that you may regret calling it that (without decoration or a trademark) when you come to make your second controller design. We do not have formal rules against it at this time but probably will soon.

We are also making sure that interaction profiles added in vendor extensions (the actual profile path itself) is also decorated with your vendor ID, so that we can remove it to perform any renames needed when/if it is promoted to KHR or core.

Also, in the 1.0.27 release we introduced describing interaction profiles additionally in the XML. The spec text is not (yet) generated from that part of the XML, but please add it since tooling is being worked on that uses it. (There is some checking of those entries in ./checkSchematron.sh)

(It is OK to force-push over your old branch, you do not need to open a new MR if you rebase or amend commits)

hjiang36 commented 1 year ago

@rpavlik Thanks for the comments. I updated the pull request with decorated controller name and xml entries. Please check and let me know if there is anything else needed. Thanks

hjiang36 commented 1 year ago

@rpavlik Thanks a lot for the detailed review and suggestions. I accepted all suggestions and added some description about the heartrate sensor. Please check and let me know if there is anything to be updated. Thanks a lot

hjiang36 commented 1 year ago

@rpavlik I justed modified then entries per your suggestion. If you could help review again and let me know if there is anything else to be updated, it would be greatly appreciated. Thanks

hjiang36 commented 1 year ago

@rpavlik I'm wondering if there is any update on this PR. Please let us know if there is anything we should do to move this forward. thanks a lot.

rpavlik commented 1 year ago

Released and published in 1.0.28!