search

KhronosGroup / OpenXR-Docs

OpenXR Specification sources and related material
Other
143 stars 62 forks source link

Naming style guide violations: XR_EXTX_overlay #42

Closed rpavlik closed 4 years ago

rpavlik commented 4 years ago

There are two enum types in this extension whose value names violate the style guide. Given that this is tagged as provisional, I suspect we can simply fix these (without leaving the old ones as aliases) for a release in the near future.

See the PR by a community member that brought this to my attention: https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/171

Messages for XrOverlaySessionCreateFlagBitsEXTX

Error: registry/xr.xml:1342: Got an enum value whose name does not match the pattern: got XR_OVERLAY_SESSION_CREATE_RELAXED_DISPLAY_TIME_EXTX but expected something that ended with _BIT_EXTX due to typename being XrOverlaySessionCreateFlagBitsEXTX

Messages for XrOverlayMainSessionFlagBitsEXTX

Error: registry/xr.xml:1339: Got an enum value whose name does not match the pattern: got XR_MAIN_SESSION_BIT_ENABLED_COMPOSITION_LAYER_INFO_DEPTH_EXTX but expected something that started with XR_OVERLAY_MAIN_SESSION due to typename being XrOverlayMainSessionFlagBitsEXTX Error: registry/xr.xml:1339: Got an enum value whose name does not match the pattern: got XR_MAIN_SESSION_BIT_ENABLED_COMPOSITION_LAYER_INFO_DEPTH_EXTX but expected something that ended with _BIT_EXTX due to typename being XrOverlayMainSessionFlagBitsEXTX

rpavlik-bot commented 4 years ago

An issue (number 1318) has been filed to correspond to this issue in the internal Khronos GitLab.

If you have a Khronos account, you can access that issue at KHR:openxr/openxr#1318.

rpavlik commented 4 years ago

Fixed in 1.0.8.