HelloXR Vulkan version enables USE_MIRROR_WINDOW default, and it is annoying when testing it on Windows

KhronosGroup / OpenXR-SDK-Source

Sources for OpenXR loader, basic API layers, and example code.

https://khronos.org/openxr

Apache License 2.0

679 stars 249 forks source link

HelloXR Vulkan version enables USE_MIRROR_WINDOW default, and it is annoying when testing it on Windows #392

Open utzcoz opened 1 year ago

utzcoz commented 1 year ago

See https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/tests/hello_xr/graphicsplugin_vulkan.cpp#L21.

From the comment, USE_MIRROR_WINDOW shows a dummy window when running Vulkan version of HelloXR on Windows platform, and this window is used for RenderDoc. As a normal tester, I don't use RenderDoc, and I just want the Runtime to display a native window to show the rendered content. What about disabling it default? If other folks want to run it with RenderDoc, they can build it with patch to enable USE_MIRROR_WINDOW macro.

rpavlik commented 1 year ago

hmm, I don't think I had actually seen this, though I guess I run CTS more often than hello XR. Seems reasonable to have it off by default, and/or make it switchable.

utzcoz commented 1 year ago

@rpavlik I sent a new PR to disable it default. If developers want to debug it with RenderDoc, they can modify the code and build and run it manually.

rpavlik-bot commented 1 year ago

An issue (number 1981) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1981 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.