search

KhronosGroup / OpenXR-SDK-Source

Sources for OpenXR loader, basic API layers, and example code.
https://khronos.org/openxr
Apache License 2.0
637 stars 238 forks source link

hello_xr vulkan backend ignores `minApiVersion` from graphics requirements structs #448

Open fredemmott opened 6 months ago

fredemmott commented 6 months ago

VK 1.0 is hardcoded here: https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/820278f99f98928ac1f3d27916c4aa24c6539521/src/tests/hello_xr/graphicsplugin_vulkan.cpp#L1386

For XR_KHR_vulkan_enable2, the version can (should) be forced by the runtime or an API layer's implementation of xrCreateVulkanInstanceKHR, however this isn't supported via XR_KHR_vulkan_enable - for the older OpenXR extension, the app should respect the min api version from XrGraphicsRequirementsVulkanKHR and use it for vkCreateInstance()

rpavlik-bot commented 5 months ago

An issue (number 2208) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2208 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.