KhronosGroup / OpenXR-SDK-Source

Sources for OpenXR loader, basic API layers, and example code.
https://khronos.org/openxr
Apache License 2.0
653 stars 244 forks source link

Broken docker link in "Building the OpenXR Specification" page #476

Closed dgough closed 3 months ago

dgough commented 4 months ago

The URL to the docker file in Building the OpenXR Specification is broken. I assume it is supposed to be:

https://github.com/KhronosGroup/DockerContainers/blob/main/openxr-sdk.Dockerfile

Also, the instructions mention open-in-docker.sh, but I don't see that anywhere.

rpavlik commented 4 months ago

Good catch, yes we did rename that file a while back. (the one you linked is actually for SDK build, not for the spec build.) The images are pushed to docker-hub however.

Since those docs (and the container) are intended for spec build, the open-in-docker script is only in the docs repo (as well as the private Khronos monorepo): https://github.com/KhronosGroup/OpenXR-Docs/blob/main/open-in-docker.sh

Since we do have the loader doc in this repo, I suppose it might make sense to ship it in this one too, I'll adjust that for the next release.

rpavlik-bot commented 4 months ago

An issue (number 2283) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2283 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

rpavlik commented 4 months ago

OK, I have an internal MR to fix the docs and ship the script in this repo too, I anticipate it will be merged for the next release.

rpavlik commented 3 months ago

Fixed in 1.1.37, thanks for the report!