xr_linear.h XrQuaternionf_Multiply(r, a, b) returns product of b * a not a * b.

KhronosGroup / OpenXR-SDK-Source

Sources for OpenXR loader, basic API layers, and example code.

https://khronos.org/openxr

Apache License 2.0

657 stars 244 forks source link

xr_linear.h XrQuaternionf_Multiply(r, a, b) returns product of b * a not a * b. #502

Open jzulauf-lunarg opened 1 week ago

jzulauf-lunarg commented 1 week ago

Looking at the signs of the cross terms they reflect the commuted order of multiplication.

As there doesn't appear to be either unit test, nor documentation it's not clear if this is intended behavior and simply undocumented, or whether it's simply an error (or something I don't understand ).

Also, as this function is called from several other locations within the header, it's not clear as to their correctness.

jzulauf-lunarg commented 1 week ago

@rpavlik -- this git blames to you. Not sure about ownership.

rpavlik-bot commented 5 days ago

An issue (number 2372) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2372 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.