KhronosGroup / OpenXR-Tutorials

OpenXR Tutorials
https://www.openxr-tutorial.com/
Apache License 2.0
72 stars 15 forks source link

Tutorial setup chapter unclear sentence #100

Closed pfontain closed 6 months ago

pfontain commented 8 months ago

I find the sentence "There are both compile and runtime checks to select the requested Graphics API, and we construct an appropriate derived class through the use of std::unique_ptr<>" a little unclear.

AndrewRichards-Code commented 7 months ago

Hi @pfontain,

The compile-time checks are controlled by the XR_TUTORIAL_USE_... pre-processor statements, which are set up by the CMakeLists.txt, and the runtime checks are done by the CheckGraphicsAPI_TypeIsValidForPlatform() function in GraphicsAPI.cpp. I hope this helps.

pfontain commented 6 months ago

Created https://github.com/KhronosGroup/OpenXR-Tutorials/pull/118 to add some of this information.

rbessems commented 6 months ago

Thanks Paul, your MR has been merged!

pfontain commented 6 months ago

You're welcome. It's Paulo ;)

rbessems commented 6 months ago

Thanks Paulo :)