search

KhronosGroup / OpenXR-Tutorials

OpenXR Tutorials
https://www.openxr-tutorial.com/
Apache License 2.0
84 stars 15 forks source link

build.gradle loader version ignored #109

Open Xelarse opened 10 months ago

Xelarse commented 10 months ago

The build gradles for each chapter include this dep (In this snippet I've bumped the version) implying that its pulling the loader as a dependancy:

E.G ./Chapter5/app/build.gradle

dependencies {
    implementation 'org.khronos.openxr:openxr_loader_for_android:1.0.33'
}

but it gets completely ignored because the cmakes for each chapter pulls the loader source directly and use that:

E.G ./Chapter5/CMakeLists.txt

FetchContent_Declare(
    OpenXR
    URL_HASH MD5=81930f0ccecdca852906e1a22aee4a45
    URL https://github.com/KhronosGroup/OpenXR-SDK-Source/archive/refs/tags/release-1.0.28.zip
        SOURCE_DIR
        openxr
)
FetchContent_MakeAvailable(OpenXR)

It caught me out at least cause the loader that I needed for some testing relied on a version newer than 1.0.28 but still kept getting 1.0.28 regardless of what I did to the gradle dependancy.

rpavlik-bot commented 7 months ago

An issue (number 2266) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2266 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

rbessems commented 1 month ago

The issue is that we are building for multiple platforms, there will always be two spots needing to be changed in this design for Android. I'll leave this bug open for now so others can see it. (and potentially for us to fix in the future)