KhronosGroup / OpenXR-Tutorials

OpenXR Tutorials
https://www.openxr-tutorial.com/
Apache License 2.0
86 stars 15 forks source link

Create Diagrams for XrSpaces #45

Closed AndrewRichards-Code closed 1 year ago

AndrewRichards-Code commented 1 year ago

Create 3D diagrams for XrSpaces to be used in Chapter 3.

AndrewRichards-Code commented 1 year ago

From the OpenXR Tutorial Review Meeting on 2023/08/22 at 14:00 UTC, we agreed that the best solution would be to find the original graphic designer for the diagrams referenced here: https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#semantic-path-standard-pose-identifiers (Figure 2), and for them to create the diagrams for XrSpaces. Simul can also try a find a graphic designer for the same purpose.

rvkennedy commented 1 year ago

ViewSpace This is the first of the new illustrations: comments/suggestions?

rbessems commented 1 year ago

I think the image is probably good for the broad idea what view space is but should not be used for the actual pose of the view space.

Maybe slice off most of the body to keep the image reasonably sized.

rvkennedy commented 1 year ago

What would you like to see @rbessems? I think we're looking for a non-neutral pose. But unless we're looking at the back of the head, the Z-axis will be pointing away from the viewer.

rbessems commented 1 year ago

Let me post it internally for more visibility

rbessems commented 1 year ago

So the feedback that came said move the center forward more right between the eyes, it almost looks as if it is inside the head currently.

rbessems commented 1 year ago

Also make sure that x, y and z are either labeled in the graph, or clearly labeled in the tutorial overall.

rvkennedy commented 1 year ago

ViewSpace

rvkennedy commented 1 year ago

Here the centre has been placed between the eyes at the front of the head. The Z-axis is wholly enclosed but still quite clear I think. Axis labels have been added, and the torso has been cropped.

rbessems commented 1 year ago

Looks great!

rvkennedy commented 1 year ago

Final (?) images: LocalSpace StageSpace ViewSpace

rbessems commented 1 year ago

I'm not sure I like the local space graphic. I'll post these in the W.G. to get comments

rvkennedy commented 1 year ago

Time is short so I hope we can get some clear suggestions. One option would be to swap the "initial" and "current" head positions, then the Z axis would be more visible.

rbessems commented 1 year ago

Here is some feedback I received:

A side profile with the origin directly inside the headset to make it clear it's not at the centre of the head, but rather between the eyes might be helpful

rvkennedy commented 1 year ago

Possible alternative: LocalSpace

rbessems commented 1 year ago

I like the alternative local_space from the post right above this one.

And the group likes that stage space drawing you have above.

rvkennedy commented 1 year ago

this is the stage space with no figure. StageSpaceOnly