search

KhronosGroup / SPIRV-Cross

SPIRV-Cross is a practical tool and library for performing reflection on SPIR-V and disassembling SPIR-V back to high level languages.
Apache License 2.0
1.96k stars 549 forks source link

MSL: Improve handling of padded descriptors with argument buffers #2329

Closed HansKristian-Work closed 1 month ago

HansKristian-Work commented 1 month ago

Fix some issues with aliasing, and also ensures that declared array sizes always match the layout.

Fix #2318.

HansKristian-Work commented 1 month ago

Heads up for @billhollings and @cdavis5e on MoltenVK side. This should improve argument buffers, but I cannot easily test everything w.r.t. explicit argument buffer layouts.

billhollings commented 1 month ago

Heads up for @billhollings and @cdavis5e on MoltenVK side. This should improve argument buffers, but I cannot easily test everything w.r.t. explicit argument buffer layouts.

Thanks for the heads up. Will test and evaluate as part of updating arg buffers in MoltenVK.