search

KhronosGroup / SPIRV-LLVM-Translator

A tool and a library for bi-directional translation between SPIR-V and LLVM IR
Other
487 stars 218 forks source link

[Backport to 15] Update decorations for global variables (#2174) #2494

Closed mateuszchudyk closed 6 months ago

mateuszchudyk commented 7 months ago

This change is basically an update of #1389 for spec changes.

Implementation of the feature was based on Intel extension which was not officially published to Khronos. Now it has been split, updated, and published to Khronos by KhronosGroup/SPIRV-Registry#205

Summary of the things that have changed:

Capability names and a new capability was added Values for decorations have been updated to enums Decoration names and IDs have been changed Specs: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/INTEL/SPV_INTEL_global_variable_fpga_decorations.asciidoc https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/INTEL/SPV_INTEL_global_variable_host_access.asciidoc

asudarsa commented 7 months ago

Please try to fix the clang-tidy issue. otherwise LGTM.

mateuszchudyk commented 6 months ago

Please try to fix the clang-tidy issue. otherwise LGTM.

Done.