Closed vmaksimo closed 2 months ago
Should we also add assertions for other deprecated instructions: OpKill, OpAtomicCompareExchangeWeak, OpGroupMemberDecorate, OpGroupDecorate, and OpDecorationGroup?
Should we also add assertions for other deprecated instructions: OpKill, OpAtomicCompareExchangeWeak, OpGroupMemberDecorate, OpGroupDecorate, and OpDecorationGroup?
Let's do it in separate PRs. @LU-JOHN If you don't mind, could you please create and assign such issue to me?
@asudarsa Unfortunately, we don't have a good mechanism to check assertions in lit testing, so a quick test can only verify that the test fails but without any details. Although I verified locally that we do fail with the added error in case of invalid SPIR-V.
About assertions, I believe we agreed in previous PRs that for now we don't have another way to report error from
validate()
method.