search

KhronosGroup / SPIRV-LLVM-Translator

A tool and a library for bi-directional translation between SPIR-V and LLVM IR
Other
479 stars 213 forks source link

[Backport to 14] Support both legacy and Khronos version of global variable extensions (#2228) #2557

Closed wenju-he closed 4 months ago

wenju-he commented 5 months ago

This is done to provide smooth drivers transition to official extensions. Also updated tests for new extensions to use new tokens after https://github.com/KhronosGroup/SPIRV-Headers/commit/cca08c63cefa129d082abca0302adcb81610b465

(cherry picked from commit 32786ff01b612846e5dbdd7c6de99814621ca834)

wenju-he commented 5 months ago

There is an igc test which uses SPV_INTEL_global_variable_decorations fails after https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2495. I'll update the test to change SPV_INTEL_global_variable_decorations to SPV_INTEL_global_variable_host_access. Not sure if https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2495 would impact more tests, so I backport this PR. @vmaksimo could you please check if this backport makes sense? If yes, I'll backport to 15/16/17 branches as well.

wenju-he commented 4 months ago

a dozen of new regressions are reported on https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2495