search

KhronosGroup / SPIRV-LLVM-Translator

A tool and a library for bi-directional translation between SPIR-V and LLVM IR
Other
479 stars 213 forks source link

Update SPIRVRepresentationInLLVM.rst to include loop controls #2592

Closed aejjehint closed 2 months ago

aejjehint commented 4 months ago

Add section about loop controls

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

aejjehint commented 3 months ago

while LLVM passes are aware of llvm.loop metadata and even try to preserve it if possible/makes sense, what is the plan for the new metadata?

@MrSidims Like any other metadata, these metadata should be safe to be dropped if not understood. Otherwise, it would be a case by case basis depending on the loop control and whether it needs to be handled by community passes or not.

I added a statement that explains that this approach can only be used for loop controls that are not "strict requirements" and that would be acceptable to get dropped, which as I understand is the case for all current loop controls.

aejjehint commented 2 months ago

@svenvh @bashbaug can you please provide your review at your earliest convenience? Thanks!