Do not pass -DLLVM_EXTERNAL_PROJECTS="SPIRV-Headers" for an out of tree build

KhronosGroup / SPIRV-LLVM-Translator

A tool and a library for bi-directional translation between SPIR-V and LLVM IR

Other

468 stars 209 forks source link

Do not pass -DLLVM_EXTERNAL_PROJECTS="SPIRV-Headers" for an out of tree build #2634

Closed Zopolis4 closed 2 months ago

Zopolis4 commented 2 months ago

As per the CI logs:

CMake Warning:
  Manually-specified variables were not used by the project:

    LLVM_EXTERNAL_PROJECTS

-- Build files have been written to: /home/runner/work/SPIRV-LLVM-Translator/SPIRV-LLVM-Translator/build

According to https://reviews.llvm.org/D20838 it looks like this is only relevant for in-tree builds, so no need to pass it here.

CLAassistant commented 2 months ago

All committers have signed the CLA.

MrSidims commented 2 months ago

It seems we should also update README.md which mentions this argument too.

Guess we can do it on our own