search

KhronosGroup / SPIRV-LLVM

This project is no longer active. Please join us at
https://github.com/KhronosGroup/SPIRV-LLVM-Translator
Other
262 stars 60 forks source link

Khronos/spirv 3.8 #214

Closed abel-bernabeu closed 7 years ago

abel-bernabeu commented 7 years ago

Please pull two fixes: one for an issue I introduced myself and another for a unit test that was not passing on the 3.8.1 branch.

abel-bernabeu commented 7 years ago

Yes, it is the line endings. I only intend to change one line. Let me fix it before you pull

On 11 May 2017 06:12, "Yaxun (Sam) Liu" notifications@github.com wrote:

@yxsamliu commented on this pull request.

In lib/SPIRV/SPIRVUtil.cpp https://github.com/KhronosGroup/SPIRV-LLVM/pull/214#discussion_r115906162 :

@@ -1,1448 +1,1448 @@ -//===- SPIRVUtil.cpp - SPIR-V Utilities -------------------------- C++ --===//

It seems everything is treated as changed. Is it due to line ending change?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/KhronosGroup/SPIRV-LLVM/pull/214#pullrequestreview-37484528, or mute the thread https://github.com/notifications/unsubscribe-auth/AChUl09cZyoKWVWxk8uyP3BK0HtC4iepks5r4pjKgaJpZM4NXV91 .