search

KhronosGroup / SPIRV-Reflect

SPIRV-Reflect is a lightweight library that provides a C/C++ reflection API for SPIR-V shader bytecode in Vulkan applications.
Apache License 2.0
672 stars 147 forks source link

Check return values from FindNode for null pointers #228

Closed cassiebeckley closed 11 months ago

cassiebeckley commented 11 months ago

Fixes #227

cassiebeckley commented 11 months ago

Looks good overall, just one small change.

@chaoticbob what did you want me to change? I don't think it's showing up for me.

chaoticbob commented 11 months ago

Looks good overall, just one small change.

@chaoticbob what did you want me to change? I don't think it's showing up for me.

One of the comments was to add parens around the right hand side of a logical expressions.

cassiebeckley commented 11 months ago

Okay, fixed that. Anything else?