search

KhronosGroup / SPIRV-Tools

Apache License 2.0
1.09k stars 555 forks source link

spirv-fuzz: Add all opcodes that are agnostic to signedness of operands to function #3582

Open stefanomil opened 4 years ago

stefanomil commented 4 years ago

The function IsAgnosticToSignednessOfOperand of TransformationReplaceIdWithSynonym returns true when the given opcode is agnostic to the signedness of the operand at the given index.

The function only recognises some of such opcodes and it should be completed so that it includes all of the opcodes satisfying the requirement.

afd commented 3 years ago

Addressing this would involve looking carefully through the SPIR-V spec to identify instructions where the signedness of operands is not important, that are not already handled in the TransformationReplaceIdWithSynonym::IsAgnosticToSignednessOfOperand function.

Existing tests should be updated to account for the newly-identified instructions.